3 messages in net.sourceforge.lists.courier-sqwebmail[sqwebmail] (no subject)
FromSent OnAttachments
Pawel TeczaJul 10, 2006 8:22 am 
Sam VarshavchikJul 11, 2006 7:14 pm 
Pawel TeczaJul 11, 2006 11:51 pm 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:[sqwebmail] (no subject)Actions...
From:Pawel Tecza (p.te@net.icm.edu.pl)
Date:Jul 10, 2006 8:22:53 am
List:net.sourceforge.lists.courier-sqwebmail

Hello Sam,

This patch fixes all XHTML validation bugs at "Create Message" page excluding non-standard "wrap" attribute for <textarea> tag. I didn't touch it, because it's probably next your feature ;)

You forget to close <option> tags in <select> for text format and open <tr> tag for <textarea>:

--- courier-0.53.2.20060709/webmail/newmsg.c-orig 2006-07-10 17:03:32.000000000
+0200 +++ courier-0.53.2.20060709/webmail/newmsg.c 2006-07-10 17:07:59.000000000 +0200 @@ -670,12 +670,13 @@ "<p class=\"new-message-header\">" "<span class=\"new-message-header-message\">" "%s</span></p></th><td width=\"6\">&nbsp;</td>" - "<td><select name=\"textformat\"><option value=\"plain\" %s>%s" - "<option value=\"wiki\" %s>%s</select>" + "<td><select name=\"textformat\">" + "<option value=\"plain\" %s>%s</option>" + "<option value=\"wiki\" %s>%s</option></select>"

"<small>(<a href='%s/wikifmt.html' target='_blank'>%s</a>)</small>" "</td></tr>" - "<th valign=\"top\" align=\"right\">" + "<tr><th valign=\"top\" align=\"right\">" "<p class=\"new-message-header\">" "<span class=\"new-message-header-message\">" "%s</span></p></th><td width=\"6\">&nbsp;</td>",

My best regards,