4 messages in com.xensource.lists.xen-ia64-devel[Xen-ia64-devel] Re: [Xen-devel] [PAT...
FromSent OnAttachments
Takahashi Tomohiro11 Apr 2007 00:48 
Keir Fraser11 Apr 2007 07:27 
KUWAMURA Shin'ya12 Apr 2007 01:27 
KUWAMURA Shin'ya13 Apr 2007 00:10.patch
Subject:[Xen-ia64-devel] Re: [Xen-devel] [PATCH][RFC] Support GPT (GUID Partition Table)
From:KUWAMURA Shin'ya (ku@jp.fujitsu.com)
Date:04/12/2007 01:27:55 AM
List:com.xensource.lists.xen-ia64-devel

Hi Keir,

On Wed, 11 Apr 2007 15:27:53 +0100 ke@xensource.com(Keir Fraser) said:

On 11/4/07 08:48, "Takahashi Tomohiro" <taka@jp.fujitsu.com> wrote:

I made a patch for GPT support.

I don't see anything wrong with it, although won't it always be the first legacy partition that is marked with type 0xee?

No, but this patch supports the second (or third, ...) legacy partition marked with 0xee. # I have no idea whether it is necessary well...

This patch has different problems. get_active_partition() returns a entry of a legacy partition. Since the structure of GPT partition entries differs from the structure of legacy partition entries, this patch has the following problem:

- pygrub cannot access a domain more than 2^32 * SECTOR_SIZE because get_fs_offset() treats the offset as a 32-bit integer. In GPT, the offset must be treated as 64-bit integer.

- This patch returns a part of a GUID unique to the partition as legacy partition types. pygrub may misunderstand partition types.

I plan to fix this problem.