 | Start a set with this search |
 | Include this search in one of my sets |
 | Exclude this search from one of my sets |
 | Permalink to these results Paste this link in email or IM: |
 | Atom feed for tracking future search results Paste this URL into your reader: |
43 messages in org.apache.mina.devRe: svn commit: r659372 - /mina/branc...| From | Sent On | Attachments |
|---|---|---|
| Emmanuel Lecharny | May 22, 2008 7:40 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 7:46 pm | |
| Emmanuel Lecharny | May 22, 2008 8:02 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 8:14 pm | |
| Emmanuel Lecharny | May 22, 2008 8:21 pm | |
| Emmanuel Lecharny | May 22, 2008 8:24 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 8:30 pm | |
| Emmanuel Lecharny | May 22, 2008 8:43 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 8:48 pm | |
| Mike Heath | May 22, 2008 9:52 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 9:59 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 10:20 pm | |
| Emmanuel Lecharny | May 22, 2008 10:31 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 10:35 pm | |
| Mike Heath | May 22, 2008 10:44 pm | |
| Rich Dougherty | May 22, 2008 11:24 pm | |
| Julien Vermillard | May 22, 2008 11:37 pm | |
| 이희승 (Trustin Lee) | May 22, 2008 11:44 pm | |
| Julien Vermillard | May 23, 2008 12:13 am | |
| 이희승 (Trustin Lee) | May 23, 2008 12:39 am | |
| Michael Qi | May 23, 2008 12:46 am | |
| Stefano Bagnara | May 23, 2008 1:09 am | |
| Stefano Bagnara | May 23, 2008 1:17 am | |
| Julien Vermillard | May 23, 2008 1:21 am | |
| Brad Harvey | May 23, 2008 1:45 am | |
| Mark Webb | May 23, 2008 6:09 am | |
| Brad Harvey | May 23, 2008 6:31 am | |
| Niklas Therning | May 23, 2008 6:54 am | |
| Alex Karasulu | May 23, 2008 7:30 am | |
| Emmanuel Lecharny | May 23, 2008 7:50 am | |
| Emmanuel Lecharny | May 23, 2008 8:07 am | |
| Julien Vermillard | May 23, 2008 8:44 am | |
| Stefano Bagnara | May 23, 2008 10:03 am | |
| Alex Karasulu | May 23, 2008 10:14 am | |
| Mark Webb | May 23, 2008 10:16 am | |
| Stefano Bagnara | May 23, 2008 10:26 am | |
| Stefano Bagnara | May 23, 2008 10:28 am | |
| Emmanuel Lecharny | May 23, 2008 10:40 am | |
| Mark Webb | May 23, 2008 1:43 pm | |
| Emmanuel Lecharny | May 23, 2008 2:23 pm | |
| jver...@archean.fr | May 24, 2008 11:07 pm | |
| Frédéric Brégier | May 24, 2008 11:26 pm | |
| Emmanuel Lecharny | May 25, 2008 4:00 am |
| Permalink for this message Paste this link in email or IM: |
| Permalink for this thread Paste this link in email or IM: |
| Atom feed for this thread Paste this URL into your reader: |
| Subject: | Re: svn commit: r659372 - /mina/branches/buffer/core/src/main/java/org/apache/mina/queue/DefaultByteBufferQueue.java | Actions... |
|---|---|---|
| From: | Julien Vermillard (jver...@archean.fr) | |
| Date: | May 23, 2008 8:44:58 am | |
| List: | org.apache.mina.dev | |
On Fri, 23 May 2008 12:48:23 +0900 이희승 (Trustin Lee) <trus...@gmail.com> wrote:
On Fri, 23 May 2008 12:44:00 +0900, Emmanuel Lecharny <elec...@apache.org> wrote:
이희승 (Trustin Lee) wrote:
On Fri, 23 May 2008 12:21:43 +0900, Emmanuel Lecharny <elec...@apache.org> wrote:
이희승 (Trustin Lee) wrote:
On Fri, 23 May 2008 12:02:45 +0900, Emmanuel Lecharny <elec...@apache.org> wrote:
이희승 (Trustin Lee) wrote:
Every public methods except for the constructors are overridden from its supertypes and interfaces. They all got proper JavaDoc comments. Let me know if I am missing something.
Adding a @see Class#method() in the implementation then should help. When you look at a method javadoc it's better to know where too look at : the intheritance scheme can be feilry complex, and it can be a burden to retreive the associated Javadoc.
Something like : /** * @see javax.naming.Context#close() */ public void close() throws NamingException ...
I'd just move the cursor on the method? That shows pretty nicely rendered JavaDoc in modern IDEs.
Sometime, you just have to use vi or emacs. Make it simple for users : add a @see tag. Cost almost nothing, and it helps.
I wouldn't bother with vi or emacs. They pay for what they use. Moreover, it's not 'almost nothing'.
-1.
Please revert the commit.
-1. I have a valid point not to add those @see tags.
If you really want to see them added, add them by yourself. I disagree with what you suggest anyway.
Now you are behaving like a manager, who is a bladder but does no actual action.
Due to the number of mail Emmanuel is sending, I can't say he's doing nothing here.
Julien