5 messages in org.freebsd.freebsd-smpRe: Kernel include file cleanup take ...| From | Sent On | Attachments |
|---|---|---|
| Mark Murray | Apr 22, 2001 8:11 am | |
| Bruce Evans | Apr 22, 2001 10:06 pm | |
| Mark Murray | Apr 22, 2001 11:03 pm | |
| Bruce Evans | Apr 24, 2001 3:34 am | |
| Mark Murray | Apr 24, 2001 4:10 am |
| Subject: | Re: Kernel include file cleanup take #3. | |
|---|---|---|
| From: | Mark Murray (ma...@grondar.za) | |
| Date: | Apr 24, 2001 4:10:50 am | |
| List: | org.freebsd.freebsd-smp | |
On Mon, 23 Apr 2001, Mark Murray wrote:
You actually made <sys/lockmgr.h> a subinclude of other headers that need it, and one that doesn't (<sys/conf.h> doesn't need it directly, but it includes <sys/eventhandler.h> which does).
OK. Removed it (plus some other junk) from eventhandler.
From conf?
Eventhandler now contains all it needs, and conf.h includes eventhandler.h. conf.h no longer contains lock junk.
OK. Done. For such small files I'd prefer them to be owned by the project, but I don't care enough to be religious about it.
Actually, the copyrights from the original files would be better.
That works for me.
I'm not sure if the names for the new types headers are right. Perhaps they should have a leading underscore to inhibit direct inclusion, or not have the "_types" suffix, to make them less verbose and not hint that they are limited to types.
How about _mutex.h and _lock.h?
OK.
Roger that. Done.
The pfind() changes gave about another .c files that need <sys/mutex.h> but don't include it.
Bleagh. I'll fix that.
M
-- Mark Murray Warning: this .sig is umop ap!sdn
To Unsubscribe: send mail to majo...@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message