atom feed4 messages in org.freebsd.freebsd-portsRe: scotty and tkined ports?
FromSent OnAttachments
Gene W HomickiSep 14, 1996 12:50 pm 
Eric L. HernesSep 16, 1996 6:10 am 
Satoshi AsamiSep 16, 1996 10:27 pm 
Eric L. HernesSep 17, 1996 5:13 am 
Subject:Re: scotty and tkined ports?
From:Satoshi Asami (asa@freebsd.org)
Date:Sep 16, 1996 10:27:08 pm
List:org.freebsd.freebsd-ports

* I just upgraded scotty to 2.1.3, with the included tkined. * Satoshi, could you give it the once-over before I commit. * It should use /usr/lib/tcl, etc..

Ok....

* The patch is relative to the port, it doesn't belong in * `patches/'

I can tell. :)

* +#PREFIX=/src/scotty

What's this?

* HAS_CONFIGURE= yes * GNU_CONFIGURE= yes * -CONFIGURE_ARGS= --with-x --prefix=${PREFIX} * +CONFIGURE_ARGS= --with-tcl-config=/usr/libdata/tcl * --with-tk-config=/usr/local/lib --prefix=${PREFIX}

If you have GNU_CONFIGURE, you don't need HAS_CONFIGURE and --prefix. These should be

GNU_CONFIGURE= yes CONFIGURE_ARGS= --with-tcl-config=/usr/libdata/tcl \ --with-tk-config=${PREFIX}/lib

* +WRKSRC=${WRKDIR}/scotty-2.1.3/unix

I prefer

WRKSRC= ${WRKDIR}/${DISTNAME}/unix

(one less thing to change for an upgrade).

Satoshi

P.S. I didn't test it, I assume you have already done that.... :)