1 message in com.xensource.lists.xen-devel[Xen-devel] domain setmaxmen in KB or...
FromSent OnAttachments
Jacob Gorm Hansen27 Dec 2004 07:59 
Subject:[Xen-devel] domain setmaxmen in KB or bytes?
From:Jacob Gorm Hansen (jac@diku.dk)
Date:12/27/2004 07:59:57 AM
List:com.xensource.lists.xen-devel

hi,

the maxmem parameter to DOM0_SETDOMAINMAXMEM is called max_memkb, indicating that it should be in kilobytes, but looking at the code in xen/common/dom0_ops.c:

case DOM0_SETDOMAINMAXMEM: { struct domain *d; ret = -ESRCH; d = find_domain_by_id( op->u.setdomainmaxmem.domain ); if ( d != NULL ) { d->max_pages = (op->u.setdomainmaxmem.max_memkb+PAGE_SIZE-1)>> PAGE_SHIFT; put_domain(d); ret = 0; } } break;

It seems the value is treated as being in bytes? Bug or feature?

best, Jacob