atom feed26 messages in org.kernel.vger.linux-omapRe: [PATCH 01/13] Revert "ARM: OMAP: ...
FromSent OnAttachments
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kevin HilmanMay 20, 2009 4:19 pm 
Kim KyuwonMay 21, 2009 4:37 pm 
Kevin HilmanMay 22, 2009 7:54 am 
Kim KyuwonMay 22, 2009 8:50 am 
Kevin HilmanMay 22, 2009 11:15 am 
Kim KyuwonMay 22, 2009 3:59 pm 
Russell King - ARM LinuxMay 22, 2009 4:21 pm 
Kim KyuwonMay 22, 2009 5:47 pm 
Kim KyuwonMay 24, 2009 10:33 pm 
Tony LindgrenMay 26, 2009 4:12 pm 
Russell King - ARM LinuxMay 28, 2009 8:47 am 
Kevin HilmanMay 28, 2009 9:50 am 
Kevin HilmanMay 28, 2009 11:22 am 
Subject:Re: [PATCH 01/13] Revert "ARM: OMAP: Mask interrupts when disabling interrupts, v2"
From:Kim Kyuwon (q1.@samsung.com)
Date:May 21, 2009 4:37:21 pm
List:org.kernel.vger.linux-omap

Kevin Hilman wrote:

This reverts commit 5461af5af5c6a7fee78978aafe720541bf3a2f55.

Adding a disable hook to the irq_chip is not the way to fix the problem being addressed by this patch. Instead, we need to fix support for [enable|disable]_irq_wake().

Agree with you if we can use disable_irq_wake for MPU Interrupt with not masking the IRQ. Can you explain how we can fix support for disable_irq_wake() for omap_irq_chip?

Signed-off-by: Kevin Hilman <khil@deeprootsystems.com>

--- arch/arm/mach-omap2/irq.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c index 998c5c4..08a3b99 100644 --- a/arch/arm/mach-omap2/irq.c +++ b/arch/arm/mach-omap2/irq.c @@ -134,7 +134,6 @@ static struct irq_chip omap_irq_chip = { .ack = omap_mask_ack_irq, .mask = omap_mask_irq, .unmask = omap_unmask_irq, - .disable = omap_mask_irq, };

static void __init omap_irq_bank_init_one(struct omap_irq_bank *bank)

-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html