15 messages in com.xensource.lists.xen-develRe: [Xen-devel] [rfc] [patch] more 'l...
FromSent OnAttachments
Keir Fraser28 Jun 2006 14:01 
Hollis Blanchard28 Jun 2006 14:02 
Chris Wright28 Jun 2006 14:09 
Hollis Blanchard28 Jun 2006 14:10 
Hollis Blanchard28 Jun 2006 14:18 
Hollis Blanchard28 Jun 2006 14:21 
Chris Wright28 Jun 2006 14:36 
Hollis Blanchard28 Jun 2006 14:58 
Ross Maxfield28 Jun 2006 15:41 
Chris Wright28 Jun 2006 16:04 
Steve Ofsthun29 Jun 2006 07:37 
Chris Wright29 Jun 2006 10:01 
Steve Ofsthun29 Jun 2006 10:55 
Hollis Blanchard29 Jun 2006 11:14 
Steve Ofsthun29 Jun 2006 14:03 
Subject:Re: [Xen-devel] [rfc] [patch] more 'long' in the hypervisor interface
From:Chris Wright (chr@sous-sol.org)
Date:06/28/2006 02:09:25 PM
List:com.xensource.lists.xen-devel

* Hollis Blanchard (holl@us.ibm.com) wrote:

Hi Keir, we've come across some more users of 'long' in the hypervisor interface: xen/include/public/memory.h. Unlike the dom0_ops, we can't just change these to be 64 bits because 32-bit kernels use these structures for the balloon driver.

I would like to create a new type, say "legacy_ulong_t", to cover these cases and future instances we'll undoubtedly come across. What do you think?

Signed-off-by: Hollis Blanchard <holl@us.ibm.com>

diff -r 10db0f8c710d xen/include/public/arch-x86_64.h --- a/xen/include/public/arch-x86_64.h Wed Jun 28 15:37:45 2006 -0400 +++ b/xen/include/public/arch-x86_64.h Wed Jun 28 16:02:21 2006 -0500 @@ -104,6 +104,8 @@ DEFINE_XEN_GUEST_HANDLE(xen_pfn_t); #define MAX_VIRT_CPUS 32

#ifndef __ASSEMBLY__ + +typedef unsigned long legacy_ulong_t;

What is legacy about it, this looks quite odd, and I don't think will build on i386.

thanks, -chris