10 messages in com.xensource.lists.xen-devel[Xen-devel] Re: [PATCH] xen bootloader
FromSent OnAttachments
aq27 Apr 2005 02:21.patch
aq27 Apr 2005 02:23 
Mike Wray28 Apr 2005 06:50 
aq28 Apr 2005 07:26 
Jeremy Katz28 Apr 2005 20:10 
aq28 Apr 2005 20:24 
Mike Wray29 Apr 2005 00:59 
Jeremy Katz29 Apr 2005 08:30 
aq30 Apr 2005 18:01 
Mike Wray03 May 2005 06:48 
Subject:[Xen-devel] Re: [PATCH] xen bootloader
From:aq (aqu@gmail.com)
Date:04/28/2005 08:24:42 PM
List:com.xensource.lists.xen-devel

On 4/29/05, Jeremy Katz <kat@redhat.com> wrote:

On Wed, 2005-04-27 at 18:21 +0900, aq wrote:

Here is a patch to fix few problems in Xen bootloader you sent to the list yesterday.

Thanks. Sorry for the delay in responding, I've been underwater with stuff for FC4 test3.

list of changes: - make a dummy tools/pygrub/src/__init__.py

I still don't know why this didn't work, but thanks.

- extend filesystem abstraction by adding file_exist() method. this method is used to check for existent of a file given its name. now ext2fs implements this method.

Great, thanks. My only comment about the ext2fs code for this is that you might as well inline the contents of ext2_file_exist in ext2fs_file_exist... you don't gain anything by having that for reuse that I can see.

I agree.

By the way, I am working on xfs/jfs/reiserfs module for this code. Hopefully I will finish soon.