29 messages in com.xensource.lists.xen-develRE: [Xen-devel] Uses of &frame_table[...
FromSent OnAttachments
Magenheimer, Dan (HP Labs Fort Collins)18 Dec 2005 19:18 
Ian Pratt18 Dec 2005 20:23 
Magenheimer, Dan (HP Labs Fort Collins)22 Dec 2005 15:28 
Ewan Mellor23 Dec 2005 02:28 
Keir Fraser23 Dec 2005 03:46 
Magenheimer, Dan (HP Labs Fort Collins)23 Dec 2005 05:05 
Magenheimer, Dan (HP Labs Fort Collins)23 Dec 2005 05:27 
Keir Fraser23 Dec 2005 06:37 
Ewan Mellor23 Dec 2005 07:27 
Magenheimer, Dan (HP Labs Fort Collins)23 Dec 2005 12:33 
Tian, Kevin26 Dec 2005 01:12 
Magenheimer, Dan (HP Labs Fort Collins)28 Dec 2005 14:15 
Muli Ben-Yehuda28 Dec 2005 14:23 
Magenheimer, Dan (HP Labs Fort Collins)28 Dec 2005 14:30 
Magenheimer, Dan (HP Labs Fort Collins)28 Dec 2005 14:42 
Cihula, Joseph28 Dec 2005 17:49 
Tian, Kevin28 Dec 2005 17:58 
Keir Fraser29 Dec 2005 05:47 
Magenheimer, Dan (HP Labs Fort Collins)29 Dec 2005 08:12 
Keir Fraser29 Dec 2005 08:15 
Magenheimer, Dan (HP Labs Fort Collins)29 Dec 2005 10:51 
Keir Fraser29 Dec 2005 12:33 
Magenheimer, Dan (HP Labs Fort Collins)29 Dec 2005 13:38 
Tian, Kevin29 Dec 2005 18:15 
Ewan Mellor30 Dec 2005 05:40 
Kevin Fox30 Dec 2005 08:35 
Magenheimer, Dan (HP Labs Fort Collins)30 Dec 2005 11:49 
Mark Williamson02 Jan 2006 11:22 
Hollis Blanchard03 Jan 2006 13:54 
Subject:RE: [Xen-devel] Uses of &frame_table[xfn]
From:Magenheimer, Dan (HP Labs Fort Collins) (dan.@hp.com)
Date:12/22/2005 03:28:56 PM
List:com.xensource.lists.xen-devel

I see that Keir fixed all of these. Thanks!

The balloon driver in xenlinux was also fixed, but I think this is a syntactic but not a semantic fix. In balloon_init, an assumption is made that all pages below xen_start_info->nr_pages are valid RAM. What if all pages of valid RAM are above nr_pages? Then (I think) the balloon driver will eat up all the domain's RAM. (Unlikely, but you get the drift.)

Or perhaps this assumption is always true on xenlinux/x86 (including PAE and x86_64 and later with VIRTUAL_MEM_MAP)?

I'm still working out what this should be on ia64, but the current code definitely won't work. Is it just trying to allocate N pages where N = max_reservation - initial_reservation? If so, why not just call alloc_page N times? If this works, it is probably shareable with ia64, else perhaps we will need an arch_balloon_init() (and an asm/balloon.h) otherwise...

On a related note, I'm not clear on the relationship between the "memory" variable in xmdefconfig and the two reservation variables needed for ballooning (not sure what they are named, but call them max_reservation and initial_reservation). Which of these latter correspond to "memory" in xmdefconfig and how does the other get determined?

Thanks, Dan

-----Original Message----- From: Ian Pratt [mailto:m+Ian.@cl.cam.ac.uk] Sent: Sunday, December 18, 2005 9:24 PM To: Magenheimer, Dan (HP Labs Fort Collins); Xen Mailing List Cc: ian.@cl.cam.ac.uk Subject: RE: [Xen-devel] Uses of &frame_table[xfn]

There are a number of explicit uses of &frame_table[...] remaining in Xen common code (grant_table.c and memory.c). Could these be cleaned up to use pfn_to_page(...)?

Yes, this is highly desirable. We'll need it for making the frame_table virtually mapped to support discontig memory.

Eventually, I'd imagine all uses in Xen/x86 should eventually be changed as well, but this would be a good start. (And, yes, there are some in ia64-specific code that I'll be

changing too.)

Please can someone *carefully* work up a patch and test it.