Re: [Xen-ia64-devel] [PATCH][GFW][RFC] fix EFI_SAL_SET_VECTORS - SUZUKI Kazuhiro - com.xensource.lists.xen-ia64-devel

6 messages in com.xensource.lists.xen-ia64-develRe: [Xen-ia64-devel] [PATCH][GFW][RFC...

From	Sent On	Attachments
Isaku Yamahata	13 May 2008 01:10	.patch
tgin...@free.fr	13 May 2008 03:23
Isaku Yamahata	13 May 2008 19:39	.patch
tgin...@free.fr	14 May 2008 01:43
Isaku Yamahata	14 May 2008 02:17
SUZUKI Kazuhiro	15 May 2008 23:59

Subject:	Re: [Xen-ia64-devel] [PATCH][GFW][RFC] fix EFI_SAL_SET_VECTORS
From:	SUZUKI Kazuhiro (ka...@jp.fujitsu.com)
Date:	05/15/2008 11:59:24 PM
List:	com.xensource.lists.xen-ia64-devel

Hi,

I could not boot the guest HVM when I build gfw with cached physical addresses. So I changed to uncached addresses.

I confirmed to boot it with your patch.

Thanks, KAZ

From: Isaku Yamahata <yama...@valinux.co.jp> Subject: Re: [Xen-ia64-devel] [PATCH][GFW][RFC] fix EFI_SAL_SET_VECTORS Date: Wed, 14 May 2008 18:18:03 +0900

On Wed, May 14, 2008 at 10:43:24AM +0200, tgin...@free.fr wrote:

Quoting Isaku Yamahata <yama...@valinux.co.jp>:

On Tue, May 13, 2008 at 12:24:16PM +0200, tgin...@free.fr wrote:

The uncached physical addresses are hard coded, but they aren't relocated when switching to virtual address mode.

I am not sure ConvertPointer is able to deal with uncached addresses. Anyway, using normal addresses should be harmless.

I guess that the original auther concerned about a race so that he used uncached addresses.

I don't catch your point. Uncached addresses won't prevent races.

No, it doesn't prevent. I don't understand why uncached address was used either. I had tried to guess the code intention, but I'm not sure. Kaz, any comment?