atom feed12 messages in org.kernel.vger.kernel-janitorsRe: [PATCH V2 1/4] staging: vt6556: C...
FromSent OnAttachments
Peter Senna TschudinJul 13, 2014 12:11 pm 
Peter Senna TschudinJul 13, 2014 12:11 pm 
Peter Senna TschudinJul 13, 2014 12:11 pm 
Peter Senna TschudinJul 13, 2014 12:11 pm 
Greg KHJul 13, 2014 12:32 pm 
Peter Senna TschudinJul 14, 2014 1:59 am.patch
Greg KHJul 14, 2014 5:58 am 
Peter Senna TschudinJul 14, 2014 7:02 am 
Dan CarpenterJul 14, 2014 7:12 am 
Peter Senna TschudinJul 14, 2014 10:01 am 
Dan CarpenterJul 14, 2014 10:09 am 
Greg KHJul 14, 2014 10:21 am 
Subject:Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues
From:Dan Carpenter (dan.@oracle.com)
Date:Jul 14, 2014 7:12:31 am
List:org.kernel.vger.kernel-janitors

Since you're going to redo this patch anyway, I may as well give you the normal feedback for these kinds of patches.

From 69cd87aca39730c0578592d1296b738f7f223f29 Mon Sep 17 00:00:00 2001 From: Peter Senna Tschudin <pete@gmail.com> Date: Mon, 14 Jul 2014 10:28:42 +0200 Subject: [PATCH V3] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch.

This typedef, reported by checkpatch, was removed from card.h: typedef enum _CARD_PHY_TYPE { PHY_TYPE_AUTO = 0, PHY_TYPE_11B, PHY_TYPE_11G, PHY_TYPE_11A } CARD_PHY_TYPE, *PCARD_PHY_TYPE;

The following typedefs were removed, but enums were kept at device.h: - typedef enum __device_msg_level - typedef enum __DEVICE_NDIS_STATUS

Break this kind of patch into patches which fix one type of mistake per patch: patch 1: fix whitespace stuff patch 2: remove useless returns patch 3: remove typedefs etc.

-//{{RobertYu:20060515, new BB setting for VT3226D0 +/* {{RobertYu:20060515, new BB setting for VT3226D0 */

Just delete these, because we have version control.